Conditionally use HTTPS based on platform_version #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following #225. CentOS 5 and earlier use an older version of yum, which embeds an older version of M2Crypto, that when used against a modern cipher set (i.e. no sslv3), fails when trying to retrieve the signing key with: ... File "/usr/lib64/python2.4/site-packages/M2Crypto/SSL/Connection.py", line 167, in connect_ssl return m2.ssl_connect(self.ssl, self._timeout) M2Crypto.SSL.SSLError: sslv3 alert handshake failure There doesn't seem to be any patches to update this behavior, so instead switch on SSL for any system older than 6.x, continue to use http to retrieve the key.
miketheman
added a commit
that referenced
this pull request
Oct 15, 2015
Conditionally use HTTPS based on platform_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #225.
CentOS 5 and earlier use an older version of yum, which embeds an older
version of M2Crypto, that when used against a modern cipher set (i.e. no
sslv3), fails when trying to retrieve the signing key with:
There doesn't seem to be any patches to update this behavior, so instead
switch on SSL for any system older than 6.x, continue to use http to
retrieve the key.
/cc @elafarge